CLOUDSTACK-10217: Clean up old MAC addresses from DHCP lease file#2393
CLOUDSTACK-10217: Clean up old MAC addresses from DHCP lease file#2393yadvr merged 1 commit intoapache:masterfrom
Conversation
When the IPv4 address of a Instance changes we need to make sure the old entry is removed from the DHCP lease file on the Virtual Router otherwise the Instance will still get the old lease. Signed-off-by: Wido den Hollander <wido@widodh.nl>
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
code looks fine but no validation or description of reproduction. please add test
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
I understand your comment @DaanHoogland , but I have no idea on how to test this :) We ran into this issue combined with #2388 and then needed to fix this in the Python code, this is what it resulted in. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1621 |
|
I see I forgot the label on #2388 @rhtyd , my bad! The cs_dhcp.py file in this case hasn't changed with the Debian 9 template so it's still valid. |
|
@DaanHoogland No, it's not. Changing the IP 'works' in 4.10/master, but it doesn't change the gateway. I discovered these duplicate MACs during #2388 |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1631 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-2091)
|
|
Test lgtm, and code lgtm. Considering Daan's review as lgtm, merging based on two lgtms, and purely on test results. |
4 participants
When the IPv4 address of a Instance changes we need to make sure the
old entry is removed from the DHCP lease file on the Virtual Router
otherwise the Instance will still get the old lease.
Signed-off-by: Wido den Hollander wido@widodh.nl